nightwatchjs / html-reporter

Nightwatch HTML Reporter
MIT License
3 stars 22 forks source link

Eslint issue 44 fix #55

Open JeremiahHerring opened 8 months ago

JeremiahHerring commented 8 months ago

Adding onto PR made by @subhajit20 PR #47, I went ahead and fixed the warnings with the "unexpected any." I also fixed the issue with the unexpected non-null assertion. Now when we run lint in the terminal using "npm run lint", there shouldn't be any more warnings.

This may not be correct however since I am using : @typescript-eslint/no-explicit-any : "off", which, by continuing to use any in the codebase, we're telling TypeScript to skip type checking for that variable or expression. This means that TypeScript won't catch potential type-related errors at compile-time, which can be a problem.

Would love to discuss better potential alternatives possibly, I was thinking of using "unknown" instead of "any" but I think it would change the way the components function.