nightwatchjs / nightwatch

Integrated end-to-end testing framework written in Node.js and using W3C Webdriver API. Developed at @browserstack
https://nightwatchjs.org
MIT License
11.79k stars 1.31k forks source link

Travis CI fails to run the unit tests and still ends with successful state #1657

Closed mAiNiNfEcTiOn closed 6 years ago

mAiNiNfEcTiOn commented 6 years ago

Thanks in advance for your contribution. Please follow the below steps in submitting an issue, as it will help us with addressing it quicker.

Before submitting a new issue, try searching for a similar one here: https://github.com/nightwatchjs/nightwatch/search?state=open&type=Issues.


Problem

Travis CI fails to run the unit tests and still states that the build was successful.

Possible reason

We're using node 0.10 to run the tests... perhaps upgrade to a more recent version? Something like Node 6?

Expected output

A failing build

Actual output

A passing build

1.35s$ npm test
> nightwatch@0.9.16 test /home/travis/build/nightwatchjs/nightwatch
> mocha test/src
/home/travis/build/nightwatchjs/nightwatch/node_modules/xml2json/node_modules/joi/lib/index.js:5
const Hoek = require('hoek');
^^^^^
[SyntaxError: Use of const in strict mode.]
The command "npm test" exited with 0.

Example case:

Please check this build: https://travis-ci.org/nightwatchjs/nightwatch/builds/282196126

beatfactor commented 6 years ago

Thanks, this is fixed now. Sorry for not merging your PR, I ended up with just using node 6 for now, and we'll add node 8 support at a later stage.