assert.visible failure output is too verbose

[spnraju]

Reporting a bug

• [x] Please write an elaborate title which explains the problem as accurate as possible For instance:
  • not helpful: "Issue with tags"
  • much better: "Tags don't work when combined with --skiptags option"
• [x] Include a sample test which reproduces the problem you're experiencing. The test should be against a public url. The test and other info should be posted inline, attachments will be ignored; -https://github.com/spnraju/nightwatchjs-selenium-example/tree/feature/issue-with-isvisible
• [ ] Include the verbose output, if possible (run nightwatch with --verbose argument);
• [x] Include your configuration (try to leave out the irrelevant bits);
• [x] Also include: Nightwatch version, Node.js version, OS version and Webdriver/Selenium Server version; Nightwatch : 1.0.19, 1.0.18 Node : 8 and 10
• [x] Please try not to report issues you have with individual browser drivers which cannot or should not be solved in Nightwatch.

assert.visible is failing with verbose output. I could reproduce this in 1.0.19 and 1.0.18. Could not try with any other version. This could be an issue with some other APIs under assert.

[spnraju]

Hi @beatfactor got any chance to look at this?

[beatfactor]

@spnraju Is there any improvement in v1.1.7?

[spnraju]

Thank you @beatfactor for looking into this.

Looks like it is fixed with the new version. But could see the error messages itself have changed. Is that how it should work? Screenshot below.

[beatfactor]

The error is probably not necessary if the assertion is failed already.

[spnraju]

Does it mean we are good and can close this issue?

[beatfactor]

No, if the assertion is the same as the error, than the error shouldn't be counted, so that needs to be fixed.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.

[spnraju]

Hi @beatfactor , I have tried with the latest version and the issue is still there.

[beatfactor]

This should be fixed in v1.2.

[spnraju]

Hi @beatfactor , Thank you for the fix. I have tried with latest v1.2.1 and below is the screenshot. I hope this is how it should work.

[beatfactor]

Yes, PR #2187 will address the error logging.