nightwatchjs / nightwatch

Integrated end-to-end testing framework written in Node.js and using W3C Webdriver API. Developed at @browserstack
https://nightwatchjs.org
MIT License
11.8k stars 1.31k forks source link

Firefox error: while running .getAllWindowHandles() protocol action #2197

Closed Tchoupinax closed 5 years ago

Tchoupinax commented 5 years ago

Hello,

i came back with a previous pull request i made 5 months ago. (https://github.com/nightwatchjs/nightwatch/pull/2071).

I found the same error today and it is blocking my work. According to the previous PR's comments, my fix was not good... it may change the used transport for Firefox instead of changing this (#2071) code (which will insert a breaking change for Chrome).

I reiterate my issue because i show my problem on Selenium slack and it answers me this :

Is there an update for your test framework?
the /window_handles command no longer exists - it’s now /window/handles

https://developer.mozilla.org/en-US/docs/Web/WebDriver/Commands/GetWindowHandles

What is the good way to fix that ?

Thank you :)

beatfactor commented 5 years ago

It should be fixed in v1.2.1. If it isn't, please file a new issue but this time try to keep the template and fill in those details, otherwise we can't address it. Thanks.