Invite some collaborators

[knownasilya]

There are many issues and PR's, maybe it'd be nice to see if anyone wants to help out as a collaborator. I'm sure it's overwhelming for @beatfactor alone(?).

[mrzmyr]

+1

[davidlinse]

+1 i'm on standby..

[andymost]

+1

[limsim]

+1 looks like the project is losing momentum. lots of people on the sides waiting to contribute though.

[beatfactor]

I'll try to get some PRs done soon, no worries. I have been a bit preoccupied with other stuff lately but things will be back on track soon.

On Tue, Feb 10, 2015 at 1:06 PM, Lim Sim notifications@github.com wrote:

+1 looks like the project is losing momentum. lots of people on the sides waiting to contribute though.

— Reply to this email directly or view it on GitHub https://github.com/beatfactor/nightwatch/issues/360#issuecomment-73689013 .

[knownasilya]

@beatfactor might still be a good idea to take on some regular contributors as collaborators.

[codemonkeybot]

+1

[ryanoasis]

This does seem like a good idea for some tasks at the least, all things considered

[vinogradoff]

+1

[morphar]

+1

@beatfactor what you have done here is extremely useful! Thank you! I can imagine the workload it must generate.

It would be great to see more collaborators on this project - both to keep you sane, but also to keep momentum and see how far this project could be driven, with more people being responsible for driving things forward... Beyond what 1 person could or should be responsible for ;)

[sknopf]

+1

[kevin-miles]

+1

[brigand]

+1 if anyone has time to create a fork that merges in some of the outstanding pull requests and more fixes can be added there, that'd be helpful to keep things moving.

I love this library, but it has some problems that need to be fixed.

And of course, it should merge back in here when @beatfactor has some time.

[davidlinse]

@brigand i think that's actually a good idea but

• i guess I remember that @beatfactor is working on a refactoring
• the syntax rules might be still too loose for such a move (merge back)
• good things take time.. ;)

~david

[gilligan]

I am starting to write ui tests at work using nightwatch but with all the open tickets I am somewhat worried.

[brigand]

I did eventually have to switch away from nightwatch. It's unfortunate because I really do like nightwatch, and I don't know anything that works better in general (using protractor because it's an angular project, which is working fine).

Nightwatch could be really great some day, but in it's current state I don't think it's practical.

[beatfactor]

That is unfortunate but hey, you win some, you lose some, right?

Many of the open issues are not relevant anymore, are questions (which is discouraged) or enhancement requests. Also PRs are merged relatively often these days since the launch of 0.6, provided they follow the guidelines.

Unfortunately some of the open PRs will most likely be rejected because they are either too large, don't have tests or don't follow the project's vision (which currently happens to be just my own :-) ). I've added contribution guideline (feel free to edit it if you have anything to add or you disagree) and I'll enforce a stricter policy with regards to reporting an issue or submit a pull request.

[sknopf]

@gilligan I recently brought nightwatch into my company and have been very happy. I find that as long as I follow the contribution guidelines, I get responses right away and issues are resolved quickly. Remember that a backlog of issues (which includes feature requests) is normal and healthy for a project this size.

[gilligan]

Just thought 90 is a worrying number because at some point you are just swamped.

@sknopf @brigand: i've been writing the first tests over the last couple of days. It mostly seems to work. There seems to be an issue with phantomjs which fails visibility asserts that work fine in chrome (i will have to file an issue for that).

At some point the selenium server invocation just started to fail and only works after x invocations.

I am not that happy with the overall API design which at least to me seems to be somewhat uncomfortable to extend/adapt. To a certain degree this might be because of the selenium integration.

In the past I used casperjs a lot which I found more convenient but now I need cross browser testing..

Sorry for the somewhat off-topic ramblings.

[sknopf]

@gilligan the browser issue definitely sounds like an issue with phantomjs rather than nightwatch. I've found phantomjs as a browser to be buggy and often doesn't behave like other browsers (issues with visibility as you saw, for example). If you need headless you may consider Xvfb with firefox :)

I haven't experienced any issues starting the selenium server though I can imagine getting into trouble if previous selenium processes aren't properly killed - you may check on that. Anyway if you find an actual issue with nightwatch, just enter an issue.

[andymost]

Sorry for off top. @gilligan I have same issue with phantomjs. Phantomjs have different behavior with visibility check. Chrome and firefox check visible element or not like user see it(opacity, visibility, display etc. css properties ). Phantomjs check just visibility. Try check css properties. Of course it is phantomjs problem.

[knownasilya]

This is probably not the thread to discuss these issues. :neckbeard: I recommend IRC or https://gitter.im/

[drptbl]

@knownasilya is there any channel for that? there is no nw.js channel neither on gitter, neither on irc and slack what makes me sad :cry:.

[quantuminformation]

After battling some issues and finding google groups very clunky I created a discord server for this.

https://discord.gg/jpzwdBc

I can't see any reason for a project of this size to have one. Happy to transfer the ownership to the Owner at any time.