Fix test not aborting when waitFor commands used with async/await.

nightwatchjs / nightwatch

Integrated end-to-end testing framework written in Node.js and using W3C Webdriver API. Developed at @browserstack

https://nightwatchjs.org

MIT License

11.79k stars 1.31k forks source link

Fix test not aborting when waitFor commands used with async/await. #4196

Closed garg3133 closed 5 months ago

garg3133 commented 5 months ago

Right now, the waitFor commands (like waitForElementVisible) when used with async/await syntax do not abort the test on failure, even when abortOnFailure is set to true.

This PR fixes that by rejecting the command node upon failure when abortOnFailure is set to true, and thus aborting the test.

The implementation around this was merged recently in #4161.

github-actions[bot] commented 5 months ago

Status

❌ No modified files found in the types directory. Please make sure to include types for any changes you have made. Thank you!.