Closed dikwickley closed 2 weeks ago
@garg3133 added some tests.
@dikwickley I just found out that we in fact already have the implementations for the computedrole and computedlabel under the command names of getAriaRole
and getAccessibleName
. So, instead of creating a new command for these two, we just need to add aliases in the existing commands (along with added test cases in the existing test files and types).
Also, for the isActive
command, it would be better to use the endpoint itself (following the standards). I see a method already present in the method-mappings
file for getting the active element, we could use that method inside the isElementActive
method to get the element id of the currently active element and then compare it with the id of the element passed. Also, the isActive
command would also require some basic tests.
@dikwickley Any updates here?
@garg3133 i will add the new aliases and will send in the code for isActive soon.
This PR adds a new
isActive()
command to the new Element API Fixes: https://github.com/dikwickley/gsoc24/issues/6Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
examples/tests
directory of the project) and running them.ecosia.js
andduckDuckGo.js
are good examples to work with.features/my-new-feature
orissue/123-my-bugfix
);