Fix #4223: Restrict suppressNotFoundErrors to NoSuchElementError

Vaibhavsahu2810 commented 2 weeks ago

Description

This pull request addresses issue #4223. The suppressNotFoundErrors property in the new Element API previously suppressed all errors encountered by the WebDriver, including errors like InvalidSelectorError. This behavior was unintended, as suppressNotFoundErrors should ideally only suppress NoSuchElementError.

Changes Made

Updated scoped-element.js to catch and handle NoSuchElementError specifically when suppressNotFoundErrors is enabled. Modified the logic to allow other errors, like InvalidSelectorError, to propagate as expected.

Steps to Reproduce the Issue

Use an invalid selector in a test command: await browser.element.find({ selector: '@something', suppressNotFoundErrors: true }); Observe that InvalidSelectorError is no longer suppressed and propagates as intended.

Proof of Work

Terminal Output The attached screenshot shows the updated terminal output, where an InvalidSelectorError is correctly thrown when an invalid selector is provided.

Unit Test A unit test was added to ecosia.js to validate this behavior. The test checks that an invalid selector throws InvalidSelectorError instead of suppressing it.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

[x ] Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
[ x] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
[x ] If you're fixing a bug also create an issue if one doesn't exist yet;
[x ] If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
[x ] Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
[x ] If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
[x] Do not include changes that are not related to the issue at hand;
[x] Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
[x] Always add unit tests - PRs without tests are most of the times ignored.

CLAassistant commented 2 weeks ago

All committers have signed the CLA.

garg3133 commented 1 week ago

Once this is fixed, the next step would be to provide more information along with the error so that the user can easily figure out where this error is coming from. In its current state, the error itself does not tell anything about its origin and which command/selector went wrong.

Vaibhavsahu2810 commented 6 days ago

@garg3133 is this okay now, I have made all the changes that are needed Thanks!

nightwatchjs / nightwatch