Fix deprecation warnings while installing Nightwatch

nightwatchjs / nightwatch

Integrated end-to-end testing framework written in Node.js and using W3C Webdriver API. Developed at @browserstack

https://nightwatchjs.org

MIT License

11.85k stars 1.34k forks source link

Fix deprecation warnings while installing Nightwatch #4306

Open garg3133 opened 1 week ago

garg3133 commented 1 week ago

Description of the bug/issue

During the installation of Nightwatch using the npm i -D nightwatch command, the following deprecation warnings are encountered:

Steps to reproduce

Install Nightwatch in an existing Node project: npm i -D nightwatch.

To create a new Node project:

mkdir test-project
cd test-project
npm init

Sample test

No response

Command to run

No response

Verbose Output

No response

Nightwatch Configuration

No response

Nightwatch.js Version

3.9.0

Node Version

No response

Browser

No response

Operating System

No response

Additional Information

No response

ansh7432 commented 6 days ago

Heyy can i work on this issue could you please assign this to me ?

garg3133 commented 6 days ago

@ansh7432 Sure, go ahead!

ansh7432 commented 6 days ago

Hey, I recently updated the glob package to version 11.0.0 in project, and fixed this issue and updated the node version

ansh7432 commented 6 days ago

I had raised the pr please check that

souravkv commented 3 days ago

Hello @garg3133 , could you please guide me because seems like mocha and archiver-utils uses older versions of glob which is transitive causing the issue . I think overriding glob :^9.0.0 only works locally but it won't work while publishing to npm , so is it possible to force them to use glob 9.0.0 or above in npm package ?

garg3133 commented 3 days ago

@souravkv Older version of archiver-utils is coming from archiver and an older version of archiver is coming from @nightwatch/nightwatch-inspector.

So, we would need to update the nightwatch-inspector package to the issue coming from the archiver-utils package.

souravkv commented 2 days ago

@garg3133 Ok , fixing nightwatch-inspector to use newer archiver would fix it , but what about mocha , latest mocha still uses glob 8.1.0

souravkv commented 2 days ago

@garg3133 should I open a issue in nightwatch-inspector repo asking to update to newer version of archiver to fix deprecated glob?

garg3133 commented 1 day ago

@souravkv You can. Also, feel free to raise a PR to update the version of archiver in nightwatch-inspector repository.

garg3133 commented 1 day ago

A PR to bump the version of glob in mocha was just merged yesterday: https://github.com/mochajs/mocha/pull/5250

souravkv commented 1 day ago

@garg3133 ok I just raised a PR in nightwatch-inspector repository . also could you please assign this issue to me.