What changes are needed for "make check" to work

[danielmotaleite]

You say The test suite may not currently run without global (but minor) changes to your system. , but make no reference on what to change for then to work.

Please add some more info

Thanks

[dridi]

Hello,

Basically, *.localhost should resolve to 127.0.0.1, which is the case on my system with no modification.

I think the test suite specifically uses img.localhost and www.localhost. You can put entries in your hosts file for instance.

Dridi

[danielmotaleite]

Thanks for the info. Maybe it should be better to replace the above phrase with this:

For the test to work, please add this line to your /etc/hosts: 127.0.0.1 www.localhost img.localhost

So this is clear what is needed

By the way, any idea (weeks, months years?) when the support for varnish5 will be ready?

Again, thanks for the help and for the plugin

[dridi]

By the way, any idea (weeks, months years?) when the support for varnish5 will be ready?

Feel free to try a pull request, I have no idea when @nigoroll will have time to work on it.

[nigoroll]

let's do this after https://github.com/varnishcache/libvmod-example/pull/2

[nigoroll]

@danielmotaleite can you please try c140ea3bf1d922ecbcc242419564ecd29dbb94f5 with 5.0 ? I suspect we only needed a tiny change for 5.0, but as I've only recently adopted this vmod, I'd appreciate an independent test.

[dridi]

FYI I restored support for 4.1 too, so you should be able to kill the 4.1 branch. It works on my laptop against both Varnish 4.1 and 5.0 but you should check for yourself first :)

[danielmotaleite]

thanks to both, been testing and this is working fine on both versions

[dridi]

Thanks for confirming, I just removed the 4.1 branch!