nigoroll / libvmod-dynamic

The Varnish dns/named director continued
BSD 2-Clause "Simplified" License
96 stars 34 forks source link

Building vmod on debian jessie with varnish 4.1.3 fails #3

Closed filidorwiese closed 6 years ago

filidorwiese commented 8 years ago

Hi! I'm trying to build libvmod-dynamic on a minimum Debian Jessie environment with Varnish 4.1.3 already installed. When trying to run autogen.sh I get this error:

$ /root/libvmod-dynamic/autogen.sh
+ aclocal -I m4 -I /usr/share/aclocal
+ libtoolize --copy --force
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'.
libtoolize: copying file `build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
+ autoheader
+ automake --add-missing --copy --foreign
src/Makefile.am:4: error: 'vmod_LTLIBRARIES' is used but 'vmoddir' is undefined
automake: warnings are treated as errors
src/Makefile.am:6: warning: variable 'libvmod_dynamic_la_SOURCES' is defined but no program or
src/Makefile.am:6: library has 'libvmod_dynamic_la' as canonical name (possible typo)
src/Makefile.am:10: warning: variable 'nodist_libvmod_dynamic_la_SOURCES' is defined but no program or
src/Makefile.am:10: library has 'libvmod_dynamic_la' as canonical name (possible typo)

I'm probably missing something obvious. Could someone point me in the right direction?

dridi commented 8 years ago

You need Varnish 4.1.4-beta1 or later if you want to build from git. From a dist archive you should then be fine with 4.1.3.

Keeping open until a docfix lands in the readme.

dridi commented 8 years ago

@nigoroll, it may be time to cut a release and upload a dist archive. Although I'd like to deal with #2 first.

How about 1.0?

filidorwiese commented 8 years ago

So if I understand correctly there is no way to compile against the current stable 4.1.3? I'll have to wait then, because I can't be running a beta version of Varnish on this server.

dridi commented 8 years ago

For some reason my (email) update from yesterday didn't make it to this issue, pasted below.

Hi again,

So if I understand correctly there is no way to compile against the current stable 4.1.3?

Not quite, only if you want to build from git (maintainer mode).

You can first build from git against 4.1.4-beta1 or 5.0.0 if you want something more stable and create a portable dist archive (by running make dist). This is what we will distribute along with releases, lifting the restrictions for downstream users.

You can then build the tarball against your current 4.1.3 and possibly even 4.1.2, which I haven't checked because I'm nowhere near a useful computer (currently using a phone).

I'll have to wait then, because I can't be running a beta version of Varnish on this server.

I don't know what's taking 4.1.4 so long, it was originally scheduled a week or two after 5.0 (or something along those lines) but the release got overtaken by events I suppose.

Overall I don't think 4.1.4-beta1 is less stable than 4.1.3, it simply has different bugs and fixes. I completely understand the beta label could be a blocker for a sysadmin, I would probably do the same.

This is why I kept this issue open until it's properly documented. I hope it clears things up a bit.

Dridi

filidorwiese commented 8 years ago

Thanks it does clear things up!

nigoroll commented 8 years ago

sorry I had taken a week off and I'm a bit behind. Hope to get back to this one soon

dridi commented 8 years ago

edit: this was the missing update mentioned above.

nigoroll commented 6 years ago

I hope everyone is fine with closing this issue which is OBE IMHO. Please reopen if you disagree