search

nigoroll / libvmod-dynamic

The Varnish dns/named director continued
BSD 2-Clause "Simplified" License
96 stars 34 forks source link

Tests failing on Varnish 6.0.2 #44

Closed philipseidel closed 5 years ago

philipseidel commented 5 years ago

I am trying to build the latest libvmod-dynamic module based on varnish 6.0.2 and tests 03 and 13 are failing. I am building from c48be899f1f9078b67daf406ba3188fa4ca1a5bd on the 6.0 branch.

# varnishd -V
varnishd (varnish-6.0.2 revision 0458b54db26cfbea79af45ca5c4767c7c2925a91)
Copyright (c) 2006 Verdens Gang AS
Copyright (c) 2006-2018 Varnish Software AS

test-suite.log

slimhazard commented 5 years ago

I'm also seeing the error in test03, with the same EXPECT failing:

**   top   3.4 === varnish v1 -expect n_vcl == 2
[...]
---- v1    8.4 Not true: n_vcl (1) == 2 (2)

But not test13.

slimhazard commented 5 years ago

The previous commit just backports a fix from the master branch, and it only affects the test script. Changes in Varnish master had changed the way Varnish reacts to the test, and these changes have been backported to 6.0.2.

With that I'm getting all tests passing. Will have to continue investigating how to reproduce the problem in test13.

slimhazard commented 5 years ago

@philipseidel can you try the build & tests again with current branch 6.0?

If it succeeds this time, then the good news is that there weren't any problems with the VMOD, the fixes (so far at least) were only for the tests.

philipseidel commented 5 years ago

@slimhazard This looks good now. All tests are passing on the latest commit.

============================================================================
Testsuite summary for libvmod-dynamic 0.4
============================================================================
# TOTAL: 13
# PASS:  13
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

Thanks for the help!