nigoroll / varnish_timeouts

collaboration on a VIP for varning timeout reform (VTR)
0 stars 0 forks source link

Dedicated parameter tweaks #3

Closed dridi closed 3 years ago

dridi commented 3 years ago

Timeout parameters currently have a "seconds" unit (side note, why do we use plural for "Units" in the manual?) which has some disadvantages. For starters it's not possible to specify an actual unit:

param.set resp_idle_timeout 1m

It's also not clear what a zero timeout would mean between disabled and an immediate trigger. With dedicated tweaks we could solve both limitations. First, a "duration" tweak that optionally takes an actual unit, or falls back to seconds if omitted. Second, a "timeout" tweak that accepts the string "disabled" or falls back to a duration.

param.set pipe_task_timeout disabled

The "duration" tweak could generally replace the "seconds" unit.


And since I have your attention, I pushed https://github.com/nigoroll/varnish_timeouts/commit/2624140ad80027326a8c4035341d0547c054599c directly.