search

nih-cfde / gene-expression-browser

CFDE/GTEx gene expression browser prototype
0 stars 1 forks source link

Find a home for the Javascript and CSS files #22

Open RLC-DCPPC opened 2 years ago

RLC-DCPPC commented 2 years ago

Put in existing static folder and establish tag and release process and incorporate using npm

RLC-DCPPC commented 2 years ago

Why can I not add Mike D'Arcy or Karl C to this issue?

jonathancrabtree commented 2 years ago

Here are a couple of examples showing how the viewers (one for the Gene page and one for the Anatomy page) are currently referenced:

https://mii.podvis.org/cfde-ge1/gene.html https://mii.podvis.org/cfde-ge1/anatomy.html

There are multiple viewers but only a single set of JavaScript and CSS files that need to be packaged up and released. I'll have to look into whether it's possible to compile/package these in such a way that we don't have to use the "anatomy?numTopGenes=25" style for passing parameters (I think this was mentioned as a potential problem for hosting this as static S3 content.)

karlcz commented 2 years ago

The source of those pages actually uses #/anatomy?... which puts it all in the URL fragment (to the right of #) so this is all good. Those are interpreted by the browser/page and not sent to the server when requesting the HTML sources.

mikedarcy commented 2 years ago

I was able to get this deployed to the dev server, but it required some changes in how the VUE app was built in production mode, due to the fact that we need this app to function when deployed to a sub-path off of the web root and therefore needed some configuration for finding code and assets at relative URL paths. I've submitted these changes as PR #23.

You can see the app functioning on dev with the following URLs, similar to the ones referenced above:

https://app-dev.nih-cfde.org/gexb/#/gene_tissues?gencode_id=ENSG00000000003&width=1200&height=450&numTopTissues=10&tissueSiteDetailIds=Liver,Lung

https://app-dev.nih-cfde.org/gexb/#/anatomy?uberon_ids=UBERON%3A0002369,UBERON%3A0002037&width=1400&height=550&numTopGenes=25