Training history and overview - Githubissues

nih-cfde / training-and-engagement

Materials for the Training and Engagement Website

https://training.nih-cfde.org/

Other

25 stars 10 forks source link

Training history and overview #521

Closed raynamharris closed 2 years ago

raynamharris commented 2 years ago

PR Checklist

[x] Release label added
[x] PR category label added
[x] PR mergeable
[x] Clean build logs
[x] Linked related issues #520
[ ] Colorblindness test https://www.toptal.com/designers/colorfilter/

PR Description

This PR adds a new "workshop history" page that is written in markdown.
The html code that previously displayed the workshop history has been deleted from the home page.
An overview of the tutorials provided is added to the home page

Preview link

https://cfde-training-and-engagement--521.com.readthedocs.build/en/521/?next=https%3A%2F%2Fcfde-training-and-engagement--521.com.readthedocs.build%2Fen%2F521%2F&ticket=ST-1646184655-fFBatnJ8drMvGjfpvDMoyLrrgyRonUB3

Review format

comments, edits, welcome

Timeline

within 2 month

github-actions[bot] commented 2 years ago

Reviewer Checklist

[ ] spelling and grammar
[ ] successful run of all installation and code chunks
[ ] sufficient explanation and details for the tutorial content
[ ] code syntax and naming convention
[ ] adherence of tutorial format to style guide
[ ] functional links (inter and intra)
[ ] accessible hyperlink text

raynamharris commented 2 years ago

ready for review

ACharbonneau commented 2 years ago

the training link at the bottom appears to be broken:

ACharbonneau commented 2 years ago

i think it would be good if the portal demo and hmp thing from the hackathon had the video links as well

ACharbonneau commented 2 years ago

This is a very weird sentence:

the CFDE has been hosting free, virtual free, virtual training events covering general and advanced topics in bioinformatics.

ACharbonneau commented 2 years ago

clicking on the workshop history link here:

forces the link to open in a new tab. can we not do that? I think it's a setting from when we were sending them to the other website

ACharbonneau commented 2 years ago

the numbering feels weird to me since they are in reverse chronological order. I like the order tho. Could we move the date to the front and lose the numbering? I think that would make it make more sense

ACharbonneau commented 2 years ago

Since you have color coding in the plot, maybe it would be cool to have color-coded list dots in front of the dates? so you could tell at a glance which ones were which.

ACharbonneau commented 2 years ago

In the plot:

I don't think these numbers are right. I didn't have workshops with zero attendees.

the numbers are not on the right

ACharbonneau commented 2 years ago

the names don't always match between the plot and the list:

ACharbonneau commented 2 years ago

This is the same lesson, but keeps changing names

raynamharris commented 2 years ago

Excellent points. Will correct those things.

raynamharris commented 2 years ago

hyperlink removed from figure. and workshops with 0 attendance (in the future) removed

raynamharris commented 2 years ago

made names more consistent, changed list to bullets, fixed opening paragraph

ACharbonneau commented 2 years ago

hyperlink removed from figure. and workshops with 0 attendance (in the future) removed

OH IT WAS THE FUTURE! I was never going to guess that. lulz