Closed raynamharris closed 2 years ago
ready for review
the training link at the bottom appears to be broken:
i think it would be good if the portal demo and hmp thing from the hackathon had the video links as well
This is a very weird sentence:
the CFDE has been hosting free, virtual free, virtual training events covering general and advanced topics in bioinformatics.
clicking on the workshop history link here:
forces the link to open in a new tab. can we not do that? I think it's a setting from when we were sending them to the other website
the numbering feels weird to me since they are in reverse chronological order. I like the order tho. Could we move the date to the front and lose the numbering? I think that would make it make more sense
Since you have color coding in the plot, maybe it would be cool to have color-coded list dots in front of the dates? so you could tell at a glance which ones were which.
In the plot:
I don't think these numbers are right. I didn't have workshops with zero attendees.
the numbers are not on the right
the names don't always match between the plot and the list:
This is the same lesson, but keeps changing names
Excellent points. Will correct those things.
hyperlink removed from figure. and workshops with 0 attendance (in the future) removed
made names more consistent, changed list to bullets, fixed opening paragraph
hyperlink removed from figure. and workshops with 0 attendance (in the future) removed
OH IT WAS THE FUTURE! I was never going to guess that. lulz
PR Checklist
PR Description
Preview link
https://cfde-training-and-engagement--521.com.readthedocs.build/en/521/?next=https%3A%2F%2Fcfde-training-and-engagement--521.com.readthedocs.build%2Fen%2F521%2F&ticket=ST-1646184655-fFBatnJ8drMvGjfpvDMoyLrrgyRonUB3
Review format
comments, edits, welcome
Timeline
within 2 month