search

nih-cfde / training-and-engagement

Materials for the Training and Engagement Website
https://training.nih-cfde.org/
Other
25 stars 10 forks source link

Move Reviewer Checklist to the PR template #543

Closed raynamharris closed 2 years ago

raynamharris commented 2 years ago

PR Description

This PR moves the reviewer checklist to the PR template and delete the action. I like this because it buts the reviewer checklist to the top of the issue where the checkbox are counted as complete or not. Also, when the PR isn't related to the website, it makes it easier to modify. I also added an example of a link preview and modifying the PR checklist to say when it is ready for review or merge.

Feedback Requested

Include how you would like to receive the review (direct editing, as comments, notes, etc). Delete any irrelevant reviewer checks below. Add an expected timeline to finish the review and merge the PR.

Reviewer Checklist

PR Preview

No preview. Nothing added to website.

PR Checklist

raynamharris commented 2 years ago

typo fixed :) ready for review again.