search

nih-cfde / use-case-library-build

https://use-cases.nih-cfde.org/
1 stars 1 forks source link

amanda's changes for #12 #28

Closed ctb closed 4 years ago

ctb commented 4 years ago

This is a review PR from #12, containing @ACharbonneau changes as per https://github.com/nih-cfde/use-case-library-build/pull/12#issuecomment-723734935:

@ctb I wrote a bunch of new code. It seems to all be working, but it would be great if you could give it a once over before we officially merge this branch. Specifically I added:

I did not add any error checking, mostly because I don't know what it would be. I need 'completed' and 'tutorial' to both accept blank as valid. And for 'goal' it's a whole sentence.

One thing that could be cool is if we could have the possible goals saved in a place, and I could reference them in the yaml by a number or similar. But I would want it to just port over the correct sentence, not divert me to a 'goal' page. So I'm not sure how to do it, or if it's worthwhile. Goals are here

ctb commented 4 years ago

No approval or merge, since I just created this to isolate the relevant changes since my last review of #12, but all looks good!