nih-sparc / sparc.client

Python client for NIH SPARC
https://docs.sparc.science/docs/sparc-python-client
Apache License 2.0
0 stars 8 forks source link

Pennsieve Download file API #14

Closed hsorby closed 1 year ago

hsorby commented 1 year ago

https://github.com/nih-sparc/sparc.client/blob/e76a75ede22eb924a8df9657f0be832dc66908ff/src/sparc/client/services/pennsieve.py#L292

The download file API could be improved. The files_list parameter takes a dict which is misleading at best. Also, the list_files API returns a list it seems sensible to change the files_list parameter to take a list.

athril commented 1 year ago

Closed with PR #16