Closed bisgaard-itis closed 1 year ago
I saw very similar changes in #19. Do we need this PR?
@athril yes, we need this PR since it extends the osparc API. Please see comments above for more details. thx
@bisgaard-itis please make sure this PR is rebased and in sync with main branch. I would have done it myself but I am not sure why github does not offer that option in the web UI ... . Thx
@athril @hsorby please do not forget to review this PR so it can get in the main branch asap. thx.
I have added @bisgaard-itis to the list of contributors.
@athril thanks for adding me. Unfortunately I was on holidays when I received the invite which therefore expired before I came back. Can you invite me again so I can accept it?
@athril @hsorby this branch has been rebased to nih-sparc:main
so it is ready for review.
bisgaard-itis
Re-invited.
bisgaard-itis
Re-invited.
Thanks a lot @athril. What's blocking me from merging is your change request. But that should be fixed now since I already rebased my branch. Could I get you to submit a new review?
Hi @athril, Thanks again for the invitation to be a collaborator on this repo. Would it be possible for you to submit another review? I believe this PR is ready to merge.
Looks good to me!
Thanks for the review
Thanks for merging @pcrespov
This PR adds functionality to @pcrespov's PR. In a third step we will add a tutorial.
N.B. This contains the changes in https://github.com/nih-sparc/sparc.client/pull/7. Hence that one should be merged first and then the diff here will be smaller.