Increase test coverage in osparc and other minor fixes - Githubissues

nih-sparc / sparc.client

Python client for NIH SPARC

https://docs.sparc.science/docs/sparc-python-client

Apache License 2.0

0 stars 8 forks source link

Increase test coverage in osparc and other minor fixes #19

Closed pcrespov closed 1 year ago

pcrespov commented 1 year ago

Addresses test-coverage failure in main's CI and other minor fixes:

Increases test coverage of osparc module to 100%
Minor adjustments in makefile to visualize coverage report
Fixes typo in doc https://github.com/nih-sparc/sparc.client/pull/17#discussion_r1259111183

NOTE to repo owners:

It would be desirable to have a test-coverage job also in the pull-request CI. This way we can note any issue before the pull-request gets merged to main.
I would like to suggest to configure the reponsitory so that "squash" is enforced when merging pull-requests to the main branch (see doc ). I did not notice last time and all my individual commits ended up in main which IMO added unnecessary noise to the history of this branch.

athril commented 1 year ago

I changed allow squashed merging from "Default message" to "Default pull request title". Is this what you meant @pcrespov ?