search

nih-sparc / sparc.client

Python client for NIH SPARC
https://docs.sparc.science/docs/sparc-python-client
Apache License 2.0
0 stars 8 forks source link

Elastic-metadata-v1 #25

Closed jgrethe closed 9 months ago

jgrethe commented 9 months ago

K-Core metadata search services via Elasticsearch. These services submit queries against an Elasticsearch index that is identical to the Algolia search index.

jgrethe commented 9 months ago

@athril Any updates on reviewing this Pull request?

The tutorial documentation depends on this pull request.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (0ae72a5) 100.00% compared to head (ab19683) 81.91%. Report is 3 commits behind head on main.

Files Patch % Lines
src/sparc/client/services/metadata.py 26.31% 84 Missing :warning:
src/sparc/client/zinchelper.py 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #25 +/- ## ============================================ - Coverage 100.00% 81.91% -18.09% ============================================ Files 8 9 +1 Lines 346 470 +124 ============================================ + Hits 346 385 +39 - Misses 0 85 +85 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

athril commented 9 months ago

Hi @jgrethe , could you take a look at tests/test_zinc.py? It seems that the code doesn't reach 100% test coverage. Also, if you clone a repo we shouldn't see the test failure for Sphinx build. Thank you!

jgrethe commented 9 months ago

@athril - we have nothing to do with tests/test_zinc.py. Only showed up in this pull request due to Github's way of showing changes with a remerged branch. Have created a new "clean" pull request. S0 closing this one.