nih-sparc / sparc.client

Python client for NIH SPARC
https://docs.sparc.science/docs/sparc-python-client
Apache License 2.0
0 stars 8 forks source link

Automations for sparc.client #37

Closed athril closed 8 months ago

athril commented 9 months ago

This pull request includes the following:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (87c7056) 100.00% compared to head (0a419f6) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 8 8 Lines 369 370 +1 ========================================= + Hits 369 370 +1 ``` | [Flag](https://app.codecov.io/gh/nih-sparc/sparc.client/pull/37/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nih-sparc/sparc.client/pull/37/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc) | `100.00% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

athril commented 9 months ago

I have also updated Sphinx.yml workflow. It seems it used to be launched and deploy docs on each pull request (should be run only on push to main). Please let me know what you think @pcrespov.

athril commented 9 months ago

There are some review dog formatting issues to address.

All formatting issues have been resolved. Ready to merge?

athril commented 9 months ago

Thank you @pcrespov for approving the changes. Any other comments/suggestions @hsorby @bisgaard-itis ? I would like to merge it by the end of the month at the latest.