nih-sparc / sparc.client

Python client for NIH SPARC
https://docs.sparc.science/docs/sparc-python-client
Apache License 2.0
0 stars 8 forks source link

Integration of osparc as O2SparcService #7

Closed pcrespov closed 1 year ago

pcrespov commented 1 year ago

Targets for 'sparc.client':

devenv create a development environment (configs, virtual-env, hooks, ...) install-dev installs package in editable mode test-dev runs tests clean-venv Removes .venv into original configuration clean-hooks Uninstalls git pre-commit hooks clean cleans all unversioned files in project and temp files create by this makefile


   - [pre-commit hooks](https://pre-commit.com/) installs git hooks that run on every commit . e.g. to format code etc ...
hsorby commented 1 year ago

The Makefile is good for bash shells, is there an equivalent for cmd?

pcrespov commented 1 year ago

The Makefile is good for bash shells, is there an equivalent for cmd?

@hsorby do you mean windows' cmd? I have no experience with that but I guess it would require a separate bat file identical to the Makefile, right? 🤔 That would require extra maintenance but I wonder whether it is worth or not since this Makefile is intended as a development tool, i.e. users will not need them, and I assume most of us work in linux-like environment. Nonetheless, I would like to know a bit more on your thoughts on this 🙂

hsorby commented 1 year ago

Most of our people develop on Windows so a cmd version is quite desirable for us.

pcrespov commented 1 year ago

@athril any thoughts on this PR :-) I did the correction you requested and added a first integration. Thx for your feedback in advance.

athril commented 1 year ago

Hi @pcrespov, please make sure that the code is properly formatted with black and isort. Apart from that LGTM.