search

nih-sparc / sparc.client

Python client for NIH SPARC
https://docs.sparc.science/docs/sparc-python-client
Apache License 2.0
0 stars 8 forks source link

Updating pennsieve module #8

Closed athril closed 1 year ago

athril commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Base: 79.33% // Head: 67.54% // Decreases project coverage by -11.79% :warning:

Coverage data is based on head (2d2e019) compared to base (df5de6d). Patch coverage: 56.14% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## =========================================== - Coverage 79.33% 67.54% -11.79% =========================================== Files 7 7 Lines 121 151 +30 =========================================== + Hits 96 102 +6 - Misses 25 49 +24 ``` | [Impacted Files](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc) | Coverage Δ | | |---|---|---| | [tests/test\_client.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-dGVzdHMvdGVzdF9jbGllbnQucHk=) | `100.00% <ø> (ø)` | | | [src/sparc/client/services/pennsieve.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-c3JjL3NwYXJjL2NsaWVudC9zZXJ2aWNlcy9wZW5uc2lldmUucHk=) | `47.69% <32.35%> (-18.03%)` | :arrow_down: | | [src/sparc/client/client.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-c3JjL3NwYXJjL2NsaWVudC9jbGllbnQucHk=) | `85.36% <84.61%> (-3.83%)` | :arrow_down: | | [src/sparc/client/\_\_init\_\_.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-c3JjL3NwYXJjL2NsaWVudC9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/sparc/client/services/\_\_init\_\_.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-c3JjL3NwYXJjL2NsaWVudC9zZXJ2aWNlcy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/sparc/client/services/\_default.py](https://codecov.io/gh/nih-sparc/sparc.client/pull/8?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc#diff-c3JjL3NwYXJjL2NsaWVudC9zZXJ2aWNlcy9fZGVmYXVsdC5weQ==) | `71.42% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nih-sparc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nickerso commented 1 year ago

@athril - as discussed previously, PRs should originate from forks not branches in this repo...would be good to start following that similar to #7.

athril commented 1 year ago

@nickerso : I think I missed this discussion and decision. Will adhere next time. Thank you! :)

athril commented 1 year ago

Thank you @pcrespov for suggestions. I included them in this commit. As for the code coverage, we are currently refactoring pennsieve2 library that is used by sparc.client. We plan to add tests once we complete tests for pennsieve2.