nihalramesh / pe

0 stars 0 forks source link

Does not allow for duplicate names #2

Open nihalramesh opened 2 weeks ago

nihalramesh commented 2 weeks ago

Steps to Reproduce:

  1. Create a contact with a certain name
  2. Attempt to create another contact with differing email, phone, address but same name

Expected Behaviour: It is possible that two people have the same name in an organisation. However, this app does not allow for it

Screenshot 2024-11-15 at 16.16.49.png

Suggested Improvements: Allow for the same name, as long as either address / phone number is changed.

soc-pe-bot commented 2 weeks ago

Team's Response

We made this under the assumption that, realistically, two persons with the exactly same name is a rather rare occurrence, plus the user would put some sort of marker in the name field to differentiate people with same names. E.g. Prof. John Doe, John Doe Buyer ie defensive behaviour, so the user does not have to worry abt same name confusion. Therefore although there might be better way to design this feature, it is not a priority since rarely do users encounter such situation.

2E3E4420-66D1-4BB6-94A0-56E216709D1E.jpeg

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: ### Issue: No Allowance for Duplicate Names

Why It’s a Bug:

Real-World Impact:

Expected Behaviour:

Secondary Issue: Lack of Case Sensitivity

Why It’s Problematic:

Real-World Implications:


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ### Issue: No Allowance for Duplicate Names **Why It’s a Bug:** - The application currently disallows adding duplicate names, which restricts valid real-world scenarios. It is entirely possible for two individuals to share the same name, especially in large organizations or communities (e.g., two 'John Smiths'). Restricting this prevents users from accurately maintaining their contact list. **Real-World Impact:** - This behaviour could frustrate users who are unable to input multiple entries for people with identical names, particularly if the contacts have distinct phone numbers, email addresses, or other differentiators. **Expected Behaviour**: - A more appropriate approach would be to allow duplicate names but enforce uniqueness based on other attributes such as phone numbers or email addresses. This ensures data integrity without imposing unnecessary restrictions. ### Secondary Issue: Lack of Case Sensitivity **Why It’s Problematic:** - Although the application disallows duplicate names, it inconsistently handles case sensitivity. For example, 'ALAN CHEW' and 'Alan Chew' are treated as distinct individuals, despite representing the same name. This behaviour is inconsistent with the intent of preventing duplicates. This shown in the screenshot below. Take note, this is not a new screenshot, and it is the same one shown in the issue: `Birthday Reminders do not take into account birthdays exactly one week from now.` **Real-World Implications:** - Case insensitivity in detecting duplicates is crucial because users may inadvertently capitalize names differently. A consistent, case-insensitive comparison would align with user expectations and improve data reliability.