nihalramesh12629 / pe

0 stars 0 forks source link

Birthday Reminders do not take into account birthdays exactly one week from now. #15

Open nihalramesh12629 opened 1 week ago

nihalramesh12629 commented 1 week ago

The User Guide mentions Displays a contacts’ birthday if they are happening within a week from the system’s current date. I presume the system's current date, is today. I added a birthday of Nov 22, which is a week from now. However, the reminder does not pop up, when I start my application. I believe it is a edge case, and it does not consider the 7th day.

Screenshot 2024-11-15 at 17.32.56.png Screenshot 2024-11-15 at 17.33.01.png

nus-pe-bot commented 5 days ago

Team's Response

Thank you for pointing this out, we will correct it should there be future iterations.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: Screenshot 2024-11-21 at 10.38.22.png

As mentioned above, a functionality bug occurs when a functionality does not work as expected. The User Guide explicitly states that the system displays birthdays happening within a week from the system’s current date. A birthday on November 22 (seven days from today) should trigger a reminder because it falls "within a week" as per the natural interpretation of the phrase.

Observed Behavior: The application fails to include the 7th day in its range, deviating from this expectation. This is a clear "off-by-one" logic error, which is a classic example of a functionality bug.

Feature flaws generally arise from design decisions that may result in a suboptimal user experience but are intentional or inherent to the feature's design. This issue, however, is not the result of a design decision but an implementation mistake:

Why It’s Not Intentional:

Consistency Problem:

Classifying this as a feature flaw minimizes the severity of the issue.

User Confusion:

Contradiction to Documentation: