search

nihalzp / pe

0 stars 0 forks source link

Extra argument ignored can cause problems #2

Open nihalzp opened 9 months ago

nihalzp commented 9 months ago

image.png

Here, I mistakenly wrote recurrance instead of recurrence. But the app tells me nothing since it is an optional command; if the user does not inspect the output clearly, he can make wrong entry; I feel this should be handled.

nus-pe-bot commented 9 months ago

Team's Response

Thank you for your report. However, this is an intended behaviour of the program whereby the team wanted to allow more flexibility instead of throwing an error every time the user makes a minor mistake. Moreover, the output is shown for the user to validate if their input was correct.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to detect invalid input.

image.png

It can be inferred from the picture that if I add some more unnecessary and invalid "/" in the input, the program doesn't detect it and run as usual.

Considering the output, I assume that the "/" is simply omitted, which I think is not good for the stability of the project.It may result in misunderstanding if the user input contains "/" for description or other things.

Oh, and I notice that for the input:out spotify /amount 9 ////category entertainment /recurrence monthly, the output is

Nice! The following expense has been tracked:
Description                      Date          Amount        Category               Recurrence
spotify                          2023-11-17    9.00          Uncategorised          monthly

, which means the conversion of category has an error though no exception is made.

Maybe adding a judgement on it and show tips for the user to optimize his input can be a wise choice.

[original: nus-cs2113-AY2324S1/pe-interim#920] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As mentioned in UG, extraneous parameters will be simply ignored. Behaviour described by the tester is expected.

Regarding the second issue about error in conversion of category, tester has entered an invalid argument (///category), therefore the program had ignored the input as the correct argument was ‘/category’. With that, behaviour is as expected as ///category will be considered as an extraneous argument.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I think this is a bug based on the course website: Functional Bugs: A legitimate user behavior is not handled e.g. incorrect commands, extra parameters Especially, misspelling `recurrance` should be quite common.