search

nihgwu / react-native-pie

Pie chart for React Native
MIT License
107 stars 25 forks source link

Requirement of Library update for RN0.60+ #22

Closed SnehalAgrawal closed 4 years ago

SnehalAgrawal commented 5 years ago

Hello Admin, Can you please update for the React Native 0.60+ version. I have tried different ways to add ART libraries but end the end they are not working with react native's new updated version (React Native 0.60+).

Can you please check and describe any way if any?

Preeternal commented 5 years ago

Hi. Did you have problems with IOS? Just add the line below in podfile: pod 'React-ART', :path => '../node_modules/react-native/Libraries/ART'

and then install the pods

But in future we will have a real issue with ART: Warning: React Native ART has been extracted from react-native core and will be removed in a future release. It can now be installed and imported from '@react-native-community/art' instead of 'react-native'. See https://github.com/react-native-community/art

Possible, I'll abble to make PR for fix this.

Preeternal commented 5 years ago

https://github.com/nihgwu/react-native-pie/pull/23

nihgwu commented 5 years ago

landed in v0.6.0

Preeternal commented 5 years ago

Seems we need to revert back to v0.5.0 For now auto linking does not work for @react-native-community/art

landed in v0.6.0

nihgwu commented 5 years ago

maybe we should update the document for linking? https://github.com/react-native-community/art#mostly-automatic-linking

Preeternal commented 5 years ago

No. My terminal output: react-native link @react-native-community/art error Unknown dependency. Make sure that the package you are trying to link is already installed in your "node_modules" and present in your "package.json" dependencies. Run CLI with --verbose flag for more details.

nihgwu commented 5 years ago

I don't use RN for years, is there a mechanism or postinstall to do that automatically?

Preeternal commented 5 years ago

Hm.. I don't know. Need to investigate

nihgwu commented 5 years ago

What if you install the package explicitly? If it works we can make the art package to peerDependencies instead of dependencies

Preeternal commented 5 years ago

Ok. I'll try

nihgwu commented 5 years ago

any lucky? I've prepared the needed change

Preeternal commented 5 years ago

Any. I don't see the chart with this way too.

Preeternal commented 5 years ago

I'll try some different way

nihgwu commented 5 years ago

OK, then let's rollback for now

Preeternal commented 5 years ago

Yes. Differen't way also loose

nihgwu commented 5 years ago

reverted in 0.6.1

Preeternal commented 5 years ago

Problem is with @react-native-community/art I raised PR https://github.com/react-native-community/art/pull/34, but fixed with the PR only Android I'll rise PR into react-native-pie with some changes. Please merge only after successful implementation in @react-native-community/art needed changes.

nihgwu commented 5 years ago

cool, thanks

AboutReact commented 5 years ago

Working fine thank you. https://aboutreact.com/react-native-pie-chart/

zgordon01 commented 4 years ago

@Preeternal @nihgwu

I tested and everything was working fine, so https://github.com/nihgwu/react-native-pie/pull/24 has been merged which closes this issue