nihgwu / react-native-pie

Pie chart for React Native
MIT License
107 stars 25 forks source link

Better curves for rounded divider size less than 2 #37

Closed kpallik closed 4 years ago

kpallik commented 4 years ago

So I changed things to make the curve look slightly better when we have a

strokeCap='round'
dividerSize=2 ( two or less)
radius=145
innerRadius=125

its a little messy right now but I am not too sure how to make it much better any help is appreciated

here's what it looks like with the above settings and the minimum size of the arc's are 3%

Screen Shot 2020-02-10 at 11 34 18 AM
zgordon01 commented 4 years ago

@nihgwu all good?

nihgwu commented 4 years ago

@zgordon01 I don't have the full context for this change, feel free to ship it

kpallik commented 4 years ago

@zgordon01 I don't have the full context for this change, feel free to ship it

@nihgwu It allows us to not have to keep the minimum size of the sections >= 6% and overall makes the curves better.

         <PieChart
            radius={145}
            innerRadius={123}
            dividerSize={1}
            strokeCap="round"
          />

with this configuration of the PieChart we get this chart with a minimum size of the sections being only 2%

[

Screen Shot 2020-02-20 at 11 05 04 AM

](url)