nihilistzsche / LtnManager

A GUI for managing your Logistic Train Network. A mod for Factorio.
https://mods.factorio.com/mod/LtnManager
MIT License
49 stars 13 forks source link

fix/214 fix shift click on different surface #226

Closed maritz closed 1 year ago

maritz commented 1 year ago

Space Exploration mod call "remote_view_start" expects the zone_name argument to be a zone name which is different from surface names. (For example "Nauvis" (zone name) instead of "nauvis"(surface name)) To get the zone name we use the surface index and call into the remote function get_zone_from_surface_index.

fixes #214 214

For the french translation I used deepl.com, please double-check it and fix it, as I don't speak french well enough to be sure of anything.

Also fixes a wrong syntax for the util.error_flying_text call in one of the error branches.

maritz commented 1 year ago

Also: The behavior could be made more consistent (in my opinion) by going to satellite view on the same surface as well, if satellite view is available. What do you think @nihilistzsche ?

DevWolf31 commented 1 year ago

Good fix

nihilistzsche commented 1 year ago

Also: The behavior could be made more consistent (in my opinion) by going to satellite view on the same surface as well, if satellite view is available. What do you think @nihilistzsche ?

Hmm, I will ask on the discord what people think about this, but thank you for hte fix!

DevWolf31 commented 1 year ago

Also: The behavior could be made more consistent (in my opinion) by going to satellite view on the same surface as well, if satellite view is available. What do you think @nihilistzsche ?

Hmm, I will ask on the discord what people think about this, but thank you for hte fix!

Should be a setting for this?