search

niho / related

A high performance distributed graph database.
MIT License
130 stars 13 forks source link

`respond_to? :split` is true for Redis::Namespace instance #17

Closed plukevdh closed 8 years ago

plukevdh commented 10 years ago

https://github.com/sutajio/related/blob/master/lib/related.rb#L28

This test actually passes when a Redis::Namespace object is passed... which is very strange, but is apparently expected Redis::Namespace behavior to retain interop with Redis for use within Resque.

See https://github.com/resque/redis-namespace/pull/18

Should probably simply check if this is a string, not just responds to a specific method. Any reason this was not the default test?

plukevdh commented 10 years ago

Specs still passing with this change (disclaimer: on my machine :trollface:)