search

nihui / ifrnet-ncnn-vulkan

IFRNet: Intermediate Feature Refine Network for Efficient Frame Interpolation implemented with ncnn library
MIT License
95 stars 6 forks source link

Timestep arg does not do anything #1

Open n00mkrad opened 2 years ago

n00mkrad commented 2 years ago

Same issue as in rife-ncnn-vulkan.

Changing timestep argument does not have any effect.

nihui commented 2 years ago

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

Hudaldadi commented 2 years ago

it works - the GoPro models are not as impressive like Vimeo ones.

Thank sooooooo much for sharing Your great work * It works fantastic on Mac OSX!

n00mkrad commented 2 years ago

Vimeo90K models can only do 0.5 timestamp interpolation.

GoPro models can do arbitrary timestamp interpolation.

I know, but the -s argument does not work, even when using the GoPro models. -s 0.25 will do 2x interpolation instead of 4x.

Hudaldadi commented 2 years ago

maybe the -s argument is only choosing the position in time and does not generate more frames.

NeedsMoar commented 1 year ago

No, the code is just broken. When processing an entire directory, it always uses numframes / the count of files to control this. You need to specify how many frames you want and it should work. OTOH when only passing in single files only the timestep argument does anything. As clear as the -tta flag that all the upscalers provide with no documentation which sometimes lowers quality.