Denoising does not work well on large images

nihui / waifu2x-ncnn-vulkan

waifu2x converter ncnn version, runs fast on intel / amd / nvidia / apple-silicon GPU with vulkan

MIT License

3.01k stars 210 forks source link

Denoising does not work well on large images #163

Open KeygenLLC opened 2 years ago

KeygenLLC commented 2 years ago

Even moderately sized images (I tested 1500x2500 png) had almost no denoising at -n 3.

Might be good to add an option for small, medium and large images as well as multi-pass.

Small images it works pretty good. Very fast.

For working with large images (2k-10k) it's pretty useless. Probably due to how the original non-vulkan version works, though I haven't tested it.

Alex-Bujorianu commented 2 years ago

I can confirm this behaviour. If the input image has noise and a high pixel count, upscaling makes the noise noticeably more apparent—the results are comparable with the much faster lanczos upscaling used by image magic. (On my Ryzen 5 4600H, it takes 20–30s for waifu to complete the operation, compared to ~3s for image magic.) This is the image I am using: ign_animeGirlSleeping