nihui / waifu2x-ncnn-vulkan

waifu2x converter ncnn version, runs fast on intel / amd / nvidia / apple-silicon GPU with vulkan
MIT License
3.01k stars 210 forks source link

Encode image fails with webp format on scale > 2 #183

Closed ItsABlackScreen closed 2 years ago

ItsABlackScreen commented 2 years ago
Image ![001](https://user-images.githubusercontent.com/48373255/185761834-3b45684e-6de0-461b-b4ae-e1732bd47cec.jpg)
./waifu2x-ncnn-vulkan -i "001.jpg" -o "test_scale.webp" -n 3 -s 4
[0 llvmpipe (LLVM 13.0.0, 256 bits)]  queueC=0[1]  queueG=0[1]  queueT=0[1]
[0 llvmpipe (LLVM 13.0.0, 256 bits)]  bugsbn1=0  bugbilz=116  bugcopc=0  bugihfa=0
[0 llvmpipe (LLVM 13.0.0, 256 bits)]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[0 llvmpipe (LLVM 13.0.0, 256 bits)]  subgroup=8  basic=1  vote=1  ballot=1  shuffle=0
[1 AMD RADV RENOIR]  queueC=1[4]  queueG=0[1]  queueT=0[1]
[1 AMD RADV RENOIR]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[1 AMD RADV RENOIR]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[1 AMD RADV RENOIR]  subgroup=64  basic=1  vote=1  ballot=1  shuffle=1
[2 NVIDIA GeForce RTX 3060 Laptop GPU]  queueC=2[8]  queueG=0[16]  queueT=1[2]
[2 NVIDIA GeForce RTX 3060 Laptop GPU]  bugsbn1=0  bugbilz=0  bugcopc=0  bugihfa=0
[2 NVIDIA GeForce RTX 3060 Laptop GPU]  fp16-p/s/a=1/1/1  int8-p/s/a=1/1/1
[2 NVIDIA GeForce RTX 3060 Laptop GPU]  subgroup=32  basic=1  vote=1  ballot=1  shuffle=1
encode image test_scale.webp failed

Issue

Version : Release 20220728

[tested on]

Encode image fails on long images when format is set to webp. It works fine on scale 2 but on anything greater it fails with a "encode image path/to/img.webp failed." webp scale > 2 works fine on many images, but fails consistently on these long comic type images.

ItsABlackScreen commented 2 years ago

Never mind found out that webp has quiet small image dimension limitations, 16383 x 16383, and thus was failing at higher scales. Closing as not a bug.