Flowtype has extensive linting support through ESLint eslint-plugin-flowtype

niieani / typescript-vs-flowtype

Differences between Flowtype and TypeScript -- syntax and usability

MIT License

1.74k stars 78 forks source link

Flowtype has extensive linting support through ESLint eslint-plugin-flowtype #49

Open gajus opened 5 years ago

gajus commented 5 years ago

Might worth including in comparison that unlike TypeScript (?), FlowType has extensive linting support through ESLint https://github.com/gajus/eslint-plugin-flowtype plugin.

oriSomething commented 5 years ago

Why saying so? I use https://github.com/bradzacher/eslint-plugin-typescript at work and it works great

gajus commented 5 years ago

@oriSomething The last I checked that project it didn't have many rules.

Now the two projects seem comparable (26 vs 34 rules).

oriSomething commented 5 years ago

@gajus More to this compare:

A rule like use-flow-type isn't relevant to TS
There is a rule of valid-syntax which is overcome a Babylon bug. Not related to TS
There are 7 styling rules at Flow plugin comparing to 1 at TS plugin which all of them can be (and should) replaced by prettier
And more rules in the Flow plugin, that the counter to them, better used in already exist config of tsconfig.json

So, There is no real different here. It's just a personal preference

niieani commented 5 years ago

I'm happy to add a PR with a comparison that takes into account all of the nuances that @oriSomething pointed out. On that note, keep in mind TypeScript also has tslint, so eslint isn't the only option, plus flow has some built-in lints.

niieani commented 4 years ago

Btw. eslint now has type-based linting for TypeScript. It's still worth mentioning/comparing, but I think these are on par now.