search

niivue / ipyniivue

A WebGL-powered Jupyter Widget for Niivue based on anywidget
BSD 2-Clause "Simplified" License
25 stars 8 forks source link

Fix license filename #2

Closed alexisthual closed 1 year ago

alexisthual commented 1 year ago

pip install -e . fails with 

〉pip install -e .                                                                                                                                                                                                 
Obtaining file:///home/alexis/singbrain/repo/ipyniivue                                                                                                                                                             
  Installing build dependencies ... done                                                                                                                                                                           
  Checking if build backend supports build_editable ... done                                                                                                                                                       
  Getting requirements to build editable ... done                                                                                                                                                                  
  Preparing editable metadata (pyproject.toml) ... error                                                                                                                                                           
  error: subprocess-exited-with-error                                                                                                                                                                              

  × Preparing editable metadata (pyproject.toml) did not run successfully.                                                                                                                                         
  │ exit code: 1                                                                                                                                                                                                   
  ╰─> [33 lines of output]                                                                                                                                                                                         
      /tmp/pip-build-env-cqvdagud/overlay/lib/python3.10/site-packages/setuptools/dist.py:530: UserWarning: Normalizing '0.1.0.dev' to '0.1.0.dev0'                                                                
        warnings.warn(tmpl.format(**locals()))                                                                                                                                                                     
      /tmp/pip-build-env-cqvdagud/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:508: SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.       
        warnings.warn(msg, warning_class)                                                                                                                                                                          
      running dist_info                                                                                                                                                                                            
      creating /tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info                                                                                                                                                
      writing /tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/PKG-INFO                                                                                                                                        
      writing dependency_links to /tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/dependency_links.txt                                                                                                        
      writing requirements to /tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/requires.txt                                                                                                                    
      writing top-level names to /tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/top_level.txt                                                                                                                
      writing manifest file '/tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/SOURCES.txt'                                                                                                                     
      reading manifest file '/tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/SOURCES.txt'                                                                                                                     
      reading manifest template 'MANIFEST.in'                                                                                                                                                                      
      warning: no files found matching 'LICENSE.txt'                                                                                                                                                               
      warning: no files found matching '.coverage.rc'                                                                                                                                                              
      warning: no files found matching 'ipyniivue/labextension/*.tgz'                                                                                                                                              
      warning: no previously-included files found matching 'docs/#*'                                                                                                                                               
      no previously-included directories found matching 'docs/build'                                                                                                                                               
      no previously-included directories found matching 'docs/gh-pages'                                                                                                                                            
      no previously-included directories found matching 'docs/dist'                                                                                                                                                
      warning: no directories found matching 'tests'                                                                                                                                                               
      no previously-included directories found matching 'tests/build'                                                                                                                                              
      no previously-included directories found matching '**/node_modules'                                                                                                                                          
      no previously-included directories found matching 'coverage'                                                                                                                                                 
      no previously-included directories found matching 'lib'                                                                                                                                                      
      warning: no previously-included files matching '*~' found anywhere in distribution                                                                                                                           
      warning: no previously-included files matching '*.pyc' found anywhere in distribution                                                                                                                        
      warning: no previously-included files matching '*.pyo' found anywhere in distribution                                                                                                                        
      warning: no previously-included files matching '.git' found anywhere in distribution                                                                                                                         
      warning: no previously-included files matching '.ipynb_checkpoints' found anywhere in distribution                                                                                                           
      writing manifest file '/tmp/pip-modern-metadata-b0goyfho/ipyniivue.egg-info/SOURCES.txt'                                                                                                                     
      creating '/tmp/pip-modern-metadata-b0goyfho/ipyniivue-0.1.0.dev0.dist-info'                                                                                                                                  
      error: [Errno 2] No such file or directory: 'LICENSE.txt'                                                                                                                                                    
      [end of output]                                                                                                                                                                                              

  note: This error originates from a subprocess, and is likely not a problem with pip.                                                                                                                             
error: metadata-generation-failed                                                                                                                                                                                  

× Encountered error while generating package metadata.                                                                                                                                                             
╰─> See above for output.                                                                                                                                                                                          

note: This is an issue with the package mentioned above, not pip.                                                                                                                                                  
hint: See above for details.

so I guess we should rename LICENSE to LICENSE.txt :slightly_smiling_face:

hanayik commented 1 year ago

@alexisthual, thanks for this! We can merge in your fix soon. Just a warning, this repo is very much in active development, so there will likely be other issues like this. We can (And should) as a note in the README that lets people know this is a work in progress. Thanks for the PR! Hope to see you at the next OHBM brain hack.

alexisthual commented 1 year ago

No problem, I perfectly get that I'm using this without warranties :)

AnthonyAndroulakis commented 1 year ago

Thank you for the PR - will merge