search

niivue / ipyniivue

A WebGL-powered Jupyter Widget for Niivue based on anywidget
BSD 2-Clause "Simplified" License
25 stars 8 forks source link

jupyterlab 4 support #41

Closed tjni closed 5 months ago

tjni commented 1 year ago

Hello, I am new to the jupyter ecosystem, but I'm working on packaging Python projects for nixpkgs. As much as possible, we try to build a consistent package set using only the latest versions of each package. Do you know what it would take to support or upgrade to jupyterlab 4?

christian-oreilly commented 1 year ago

Good question. @AnthonyAndroulakis The reason for limiting to version 3 should be documented in an issue so that we can address it. Could you document it here when you have a moment so that we get a better sense of what effort it would involve? I think this should be addressed... it is not good to stick to old versions.

AnthonyAndroulakis commented 1 year ago

It shouldn't be too much work to support Jupyterlab 4. @tjni what errors do you have when using the package in jupyterlab 4?

tjni commented 1 year ago

We don't see any errors, but I also don't think we perform the full build -- that is, we download the sdist from PyPI and I think that already contains built JS. I did see in https://github.com/manzt/anywidget/pull/167 that there might be complications relating to the version of @jupyterlab/builder.

christian-oreilly commented 1 year ago

@AnthonyAndroulakis On our side, I think we can try relaxing this constraint in the requirement file and the CI should block if there is an issue setting up the package to run the tests. If there is an issue with Jupyter 4 that is not caught by the CI, it just means that we will need to add the test that catches this bug. Right now, the CI is broken (issue #38) so we'll need to fix this first before we can test that...