search

nijikokun / iConomy3

Please, if you fork iConomy only do so if you are really fixing or adding something useful!
7 stars 1 forks source link

Fix for newer MySQL decimal precision #14

Closed Canisaur closed 12 years ago

Canisaur commented 13 years ago

MySQL recently updated their decimal precision, and as a result iConomy is not able to create its table on newer versions of MySQL. This is a simple update that changes the MySQL database creation line to reflect the new maximum precision. (See http://dev.mysql.com/doc/refman/5.0/en/precision-math-decimal-changes.html for more info)

ShadowDrakken commented 13 years ago
read over your link... the syntax hasn't changed, what fix are you proposing? Edit: gah, nm I see... I think this is already fixed in 4.1, Coelho just didn't commit his changes when he posted 4.1 on the forum
ShadowDrakken commented 13 years ago

an additional note here, SQLite doesn't officially support DECIMAL(), it accepts it, but it casts it to INTEGER instead, so we may want to consider a change in how we handle decimals

possibly like a cash register and have iConomy shift the decimal itself

eg. inputting 2000 = $20.00 on a cash register

nijikokun commented 13 years ago

2000 should be 2,000 imo.

ShadowDrakken commented 13 years ago

I'm not talking about from a user perspective, I'm talking from the code side