nijuyonkadesu / Celestidesk

streamlines permission request / grant mechanism and, notifies employees whether their request has been approved or not through mail / sms
GNU Affero General Public License v3.0
0 stars 0 forks source link

fix(hardcode): replace all hardcoded values with string resource #17

Closed nijuyonkadesu closed 1 year ago

nijuyonkadesu commented 1 year ago

Describe the bug

The analogy of EMPLOYEE, TEAM_LEAD, MANAGER is adopted for better understanding of the application code. The actual usecase may vary. For example, if college wants to adapt this for their purpose, they might have different role names. Having them in a separate string file will reduce the refactoring costs, and reduces human error.

Expected behavior

Retrieve string resources from xml file. Maybe also attach a locale value to it.

Actual behavior

It's all hardcoded string in celestidesk

Additional context

Localization guide force a locale