search

nijuyonkadesu / SAO

Share Arts-by Overlay is an application that uses waifu.pics api. Allowing users to find a pic / gif of their interest and share it to the world!
GNU Affero General Public License v3.0
2 stars 0 forks source link

fix(crash): navigating back from settings page #18

Closed nijuyonkadesu closed 7 months ago

nijuyonkadesu commented 11 months ago

Describe the bug

Navigating from settings page to the main screen causes app to crash on Null Pointer Reference.

To Reproduce

Steps to reproduce the behavior: Check and ensure you do not pop backstack in navigation args

  1. Open SAO
  2. Click on settings
  3. Press back button

Expected behavior

It should resume from where it was left.

Actual behavior

App crashes and KeylineState is null (not my issue, probably m3 library is responsible) image

Additional context

nijuyonkadesu commented 11 months ago

Some one forgot to properly merge codes lol ?

https://sourcegraph.com/github.com/material-components/material-components-android@master/-/blob/lib/java/com/google/android/material/carousel/CarouselStrategyHelper.java?L46:23-46:41#tab=references image_2023-10-15_23-07-55

nijuyonkadesu commented 11 months ago

https://github.com/material-components/material-components-android/issues/3634

nijuyonkadesu commented 9 months ago

look on how to use saved state on navigation

  1. look at navigation docs
  2. look on how to handle back key presses ?
nijuyonkadesu commented 9 months ago

not needed, but, need to see how to restore scroll position on carousel view? ehhh...