search

nik-christou / tax-calculator

Tax calculator for multiple countries
Apache License 2.0
1 stars 0 forks source link

Navigating back does not work #20

Closed minas1 closed 4 years ago

minas1 commented 4 years ago

Reproduction steps

  1. Select the Country selection option
  2. Select a country. You will be navigated back to the main screen.
  3. Press the Back button of the device. You will be navigated back to country selection screen instead of going back to the previous page.

Tested on Chrome on Android.

nik-christou commented 4 years ago

Why is this incorrect ? The previous screen was the country selection screen. The router history is: Home -> Country Selection -> Home -> press back button -> Country Selection. Since there are only 2 views it doesn't make sense to navigate back to the same view.

minas1 commented 4 years ago

Why is this incorrect?

It's not expected by the user.

The problem is that when you choose a country you are navigated to the Main screen. Instead you should be navigated back, so that the entry is removed from the history.