search

nikaia / nova-rating-field

A Star rating field to use in your Laravel Nova apps.
MIT License
41 stars 30 forks source link

Type mixed cannot be marked as nullable since mixed already includes null #27

Open Bahramn opened 3 years ago

Bahramn commented 3 years ago

In PHP 8.0

I got this error: Type mixed cannot be marked as nullable since mixed already includes null https://github.com/nikaia/nova-rating-field/blob/6db4fdf4fc1177af401645149cda814f1fce27c3/src/Rating.php#L43

joaoguilhermels commented 3 years ago

I just removed the question mark before mixed and it worked.

airdev-web commented 2 years ago

Same problem here, can you update ?

keizah7 commented 2 years ago

Same problem

martykan commented 2 years ago

You can use this, same as the parent class Field 

public function __construct($name, $attribute = null, callable $resolveCallback = null)
zeshan77 commented 2 years ago

@martykan How? We can't make changes in the package's source code so where do you mean to put that line in order to resolve the problem?

keizah7 commented 2 years ago

@martykan How? We can't make changes in the package's source code so where do you mean to put that line in order to resolve the problem?

https://tomasvotruba.com/blog/2020/07/02/how-to-patch-package-in-vendor-yet-allow-its-updates/

sezohessen commented 1 year ago

Same problem