search

nikaia / translation-sheet

Translating Laravel languages files using a Google Spreadsheet.
GNU General Public License v3.0
291 stars 60 forks source link

Add support for columns above Z #27

Closed balping closed 6 years ago

balping commented 6 years ago

Replaces #21

This is a more efficient implementation of the same functionality.

balping commented 6 years ago

Warning

Unless you relicense this project to LGPL or GPL, including that function is a violation of LGPL.

If you don't want to relicense, probably it is safer to use composer to require the whole phpoffice/phpspreadsheet library. But that is huge, so installing it outweighs the performance gain.

But I would suggest you to change the license of this project to GPLv3. This is not a big deal, as PHP is a scripting language, it is untypical for a PHP project to be non-free, i.e. the source code is always distributed (unless some obfuscation method is used). So there isn't any practical difference between the MIT license and GPL for PHP projects. You don't even have to ask permission from the contributors of this repo: https://opensource.stackexchange.com/a/5833