Ability to work with .json translation files

nikaia / translation-sheet

Translating Laravel languages files using a Google Spreadsheet.

GNU General Public License v3.0

291 stars 60 forks source link

Ability to work with .json translation files #34

Closed satoved closed 4 years ago

satoved commented 5 years ago

Json format is not currently supported?

https://laravel-news.com/json-based-translations

Do you think it's possible to add it? Will you accept a PR?

nbourguig commented 5 years ago

Hi,

Yeah the package was built before the introduction of the json based translations files. It will need some refactoring, but I think it is faisable as there is two main classes responsible of dealing with the files (Reader, Writer).

PR are welcome.

happyDemon commented 4 years ago

pull request #45 could be a good starting point