search

nikaia / translation-sheet

Translating Laravel languages files using a Google Spreadsheet.
GNU General Public License v3.0
291 stars 60 forks source link

adding support for additional tabs in excel #51

Closed matijajanc closed 4 years ago

matijajanc commented 4 years ago

We have a case where we have Laravel for backend as API and Angular on frontend and both have translation files but in different locations and formats, so I extended your great package so we can simply add additional tabs in google sheets with specific settings like: tab name, output format (Angular using json) and location of FE translation files.

nbourguig commented 4 years ago

Hi @matijajanc,

It seems indeed like a nice addition. Can you add some tests to backup what you did, as your changes impact a lot of the internals methods ?

Tell me if could be of any help

nbourguig commented 4 years ago

Hi @matijajanc,

I took a look at what you did, and reworked it in https://github.com/nikaia/translation-sheet/pull/62

I was having an issue working with tabs (pulltab, pushtab etc..) as by design, they are already abstracted in the TranslationSheet class. (so for me a TranslationSheet = a sheet = a tab), and it didn't seems right for me that A sheet handles others sheets (or what you called tabs), and testing was kinda hard.

Anyway, i refactored the whole stuff to isolate those operations by sheets and implemented your idea.

Feature tagged in v1.4.5.