search

nikaia / translation-sheet

Translating Laravel languages files using a Google Spreadsheet.
GNU General Public License v3.0
291 stars 60 forks source link

WIP: Add Subfolder support and possibility to exclude languages from pulling #63

Closed SebastianMueller87 closed 6 months ago

SebastianMueller87 commented 4 years ago

This pull request

  1. adds subfolder support (https://github.com/nikaia/translation-sheet/pull/42 thanks to @gmvale)
  2. adds the possibility to exclude one or more languages from pulling.

Why two features within one pull request? We forked the repo of @gmvale 14 month ago. His PR got rejected in september this year. We are using his subfolder change and our additiopnal change since 14 month for a big project.

So, if you want i can split this PR up into two seperate ones. But the effort of two different PRs in comparison to the change of #42 is not in proportion (in my opinion).

@nbourguig please let me know your opinion on this and also on both feature sets. (look below for remaining todos i have to do)

Explanation of the case where the second feature is helpful:

You want to keep one language as the default/main language within the project repository. You want to define this language only by code. All other languages should get defined by the sheet. This language still needs to get pushed as an example for all translators to get the context. With this feature, you can just disable the pulling of this language via config. So in the end you have one (or more) languages that are defined by code.

Remaining Todos

nbourguig commented 6 months ago

I close this as it's been here for a long time.