nikaia / translation-sheet

Translating Laravel languages files using a Google Spreadsheet.
GNU General Public License v3.0
291 stars 60 forks source link

invalid deleteDimension when push translation #9

Closed ardani closed 7 years ago

ardani commented 7 years ago

Hi @nbourguig today im trying to push translation and i got an error like this [Google_Service_Exception]

  {                                                                                                                                              
    "error": {                                                                                                                                   
      "code": 400,                                                                                                                               
      "message": "Invalid requests[14].deleteDimension: Cannot delete a row that doesn't exist. Tried to delete row index 729 but there are onl  
  y 729 rows.",                                                                                                                                  
      "errors": [                                                                                                                                
        {                                                                                                                                        
          "message": "Invalid requests[14].deleteDimension: Cannot delete a row that doesn't exist. Tried to delete row index 729 but there are  
   only 729 rows.",                                                                                                                              
          "domain": "global",                                                                                                                    
          "reason": "badRequest"                                                                                                                 
        }                                                                                                                                        
      ],                                                                                                                                         
      "status": "INVALID_ARGUMENT"                                                                                                               
    }                                                                                                                                            
  }

I tried to solve by adding row manually in google sheet and it worked, but when I tried to push the translation again, I got the same error because columns in google sheet are limited again. i think can we add some spare row and column for it?

thanks

nbourguig commented 7 years ago

Hi,

It seems that some changes were introduced to the api or the google/api client that now raises an exception if we try to delete row/column that does not exists. Something that I need, because I don't calculate on the fly the number of translations submitted to the sheet.

Anyway, until I implement a more elegant solution, I just catched those exceptions on the delete operations. You need to pull the v1.1.1 version to get the fix.