Browser navigation does not work

[nikdo]

Steps to reproduce:

1. Navigate to few spots after each other.
2. Use back button.
3. Use forward button.

Current behavior: Spot is not changed. Browser history reacts only to home page ↔ detail page change.

[nikdo]

Findings

There is nothing wrong with react-router. There is an incorrect lifecycle method and condition for calling fetchSpotDetail from SpotDetail container. It should react to ID change too, but it should not do history.push in that case.

Tasks

• [x] call call history.push only from search
• [x] try useHistory hook
• [x] call fetchSpot on ID change from SpotDetail container
  • [x] fix useEffect condition to respect ID change
  • [x] fix condition in useEffect
  • [x] use useMatch hook
  • [x] fix or delete comment in SpotDetail
• [x] future-migrate react-router
  • [x] use useParams hook
  • [x] change to
  • [x] replace withRouter by hook

Time estimated: 6h Time spent: 4h