search

nikeee / edotor.net

Your favourite Graphviz editor
https://edotor.net
MIT License
176 stars 21 forks source link

Do not hijack Ctrl+L #41

Open yurikhan opened 2 years ago

yurikhan commented 2 years ago

The editor component used by Edotor seems to hijack the Ctrl+L shortcut for its “select line” action. In browsers, Ctrl+L is used to focus the address bar, and half the users have it in their muscle memory. (The other half uses Alt+D.)

When the current tab is Edotor and I want to focus the address bar, I subconsciously press Ctrl+L and start typing a new URL, but Ctrl+L selects my current line and the text typed next overwrites the selected line.

I use Edotor in Firefox with the custom flag browser.urlbar.openintab set to true, so focusing the address bar, typing an address and pressing Enter is my primary way of opening new tabs.

It would be nice if Edotor configured the Monaco editor to disable this binding or move it to a different key.

nikeee commented 2 years ago

This annoyed me as well.

Ref for implementation: https://github.com/microsoft/monaco-editor/issues/287#issuecomment-521166743

nikeee commented 2 years ago

New tracking issue: https://github.com/microsoft/monaco-editor/issues/102