search

nikepan / clickhouse-bulk

Collects many small inserts to ClickHouse and send in big inserts
Apache License 2.0
474 stars 86 forks source link

add TLS options: serverName & skip verify #37

Closed splichy closed 3 years ago

splichy commented 3 years ago

imagine the situation you have a single DNS record pointing to multiple clickhouse nodes, but if a single one fails then that single endpoint get marked as down - bad - so you have to list your servers one by one, but what if your certificate CN is valid only for that cluster record - now you can use tlsServerName so you can use even IP addresses, or whatever you want as long as clickhouse server certificate CN matches tlsServerName

codecov-io commented 3 years ago

Codecov Report

Merging #37 (42c0dd4) into master (2a6d515) will decrease coverage by 0.40%. The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   76.45%   76.05%   -0.41%     
==========================================
  Files           8        8              
  Lines         531      543      +12     
==========================================
+ Hits          406      413       +7     
- Misses         96       98       +2     
- Partials       29       32       +3
Impacted Files Coverage Δ
server.go 71.62% <ø> (+2.60%) :arrow_up:
clickhouse.go 79.41% <42.85%> (-3.07%) :arrow_down:
utils.go 69.76% <50.00%> (-2.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a6d515...42c0dd4. Read the comment docs.